fix: properly setting diagnostic errors when opening and closing code mirror #8631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This is a follow-up to #7166 |
franknoirot
approved these changes
Oct 21, 2025
|
@nadr0 I'd recommend reverting the two automated "Update snapshots" commits then immediately pulling in the latest |
|
Closing this because it didn't actually block Frank and to properly fix this we need to solve the LSP/KCL run time errors/Lint errors globally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When you open kcl editor the previous diagnostics are cleared and safe parse is ran and it is confusing.
Implementation
We need to not clear the diagnostics when we unmount the kcl editor. We need to call a higher level function than safeParse which is executeCode because that computes more diagnostics.
safeParse only computes parse errors
lintAst computes the LSP errors
executeAst computes the runtime KCL errors.